New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃尡 clusterctl upgrade cert-manager ignore provider CRDs #5681
馃尡 clusterctl upgrade cert-manager ignore provider CRDs #5681
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest /lgtm @fabriziopandini can you please add the error message we got before the fix in the PR description? (just for future reference) |
/hold |
/hold |
/close |
@fabriziopandini: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@fabriziopandini: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
clusterctl upgrades reads a bunch of objects from the cluster while inspecting current installation of cert-manager.
This is getting kind of critical due to CAPA introducing global resources, that we can't filter out upfront, and in case for any reason CAPA webhooks are not working this makes the operation to fail.
With this PR we are making discovery of cert-manager objects smarter (and as a positive side effect also faster), by dropping all the CRDs that belong to a provider.
/cc @sbueringer @vincepri @ykakarap