Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 clusterctl upgrade cert-manager ignore provider CRDs #5681

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
clusterctl upgrades reads a bunch of objects from the cluster while inspecting current installation of cert-manager.
This is getting kind of critical due to CAPA introducing global resources, that we can't filter out upfront, and in case for any reason CAPA webhooks are not working this makes the operation to fail.

With this PR we are making discovery of cert-manager objects smarter (and as a positive side effect also faster), by dropping all the CRDs that belong to a provider.
/cc @sbueringer @vincepri @ykakarap

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from fabriziopandini after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 16, 2021
@sbueringer
Copy link
Member

sbueringer commented Nov 16, 2021

/retest

/lgtm
(I assume manually verified, that it solves the issue)

@fabriziopandini can you please add the error message we got before the fix in the PR description? (just for future reference)

@fabriziopandini
Copy link
Member Author

/hold
I have a better fix in #5684

@fabriziopandini
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2021
@fabriziopandini
Copy link
Member Author

/close
given that #5684 is merged

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2021
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Closed this PR.

In response to this:

/close
given that #5684 is merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini fabriziopandini deleted the clusterctl-upgrade-certmanager-ignore-provider-crds branch November 23, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants