⚠️ Update references with an APIReader as fallback #5698
Conversation
k8s-ci-robot
added
cncf-cla: yes
util/conversion/conversion.go
Outdated
| // | ||
| // The object passed as input is modified in place if an updated compatible version is found. | ||
| // NOTE: In case CRDs are named incorrectly, this func is using an APIReader to list CRDs | ||
| // to avoid to implicitly create an informer for CRDs which would leads to high memory consumption. |
There was a problem hiding this comment.
NOTE: We will have to do this deprecation cycle once more when we drop the apiReader.
There was a problem hiding this comment.
I think we can do breaking changes in go code between minors, so we can drop previous signature
There was a problem hiding this comment.
I think we can do breaking changes in go code between minors, so we can drop previous signature
Do you mean changing it directly now or dropping the old one with v1.2.x?
Note: The signature we eventually need once we drop the fallback is this one: func UpdateReferenceAPIContract(ctx context.Context, c client.Client, ref *corev1.ObjectReference) error. So if we have a way to do a breaking change to the behavior of this func without cycling through other func names I would prefer not deprecating it at all.
There was a problem hiding this comment.
I'm fine doing a breaking change here, given the implications of caching entire CRDs
There was a problem hiding this comment.
Okay then let's keep it simple regarding deprecation and rotating through func names. I'll do a breaking change now to add the apiReader and we'll do another one once we don't support the fallback for the wrong CRD names anymore.
There was a problem hiding this comment.
/retitle
Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-apireader-fallback
branch
from
2d8d1ad
to
8e2369e
Compare
|
/retitle |
k8s-ci-robot
changed the title
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
@sbueringer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Implements first part of #5686