Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix contents table and header in scope and objectives #5706

Merged

Conversation

killianmuldoon
Copy link
Contributor

Fix broken formatting in the scope and objectives doc that was causing the raw doctoc text to appear in github.

Signed-off-by: killianmuldoon kmuldoon@vmware.com

Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 19, 2021
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0e1e42b into kubernetes-sigs:main Nov 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Nov 19, 2021
killianmuldoon pushed a commit to killianmuldoon/cluster-api that referenced this pull request Nov 19, 2021
…-contents

🐛 fix contents table  and header in scope and objectives
killianmuldoon pushed a commit to killianmuldoon/cluster-api that referenced this pull request Nov 19, 2021
…-contents

🐛 fix contents table  and header in scope and objectives
killianmuldoon pushed a commit to killianmuldoon/cluster-api that referenced this pull request Nov 19, 2021
…-contents

🐛 fix contents table  and header in scope and objectives
killianmuldoon pushed a commit to killianmuldoon/cluster-api that referenced this pull request Nov 19, 2021
…-contents

🐛 fix contents table  and header in scope and objectives
killianmuldoon pushed a commit to killianmuldoon/cluster-api that referenced this pull request Nov 19, 2021
…-contents

🐛 fix contents table  and header in scope and objectives
killianmuldoon pushed a commit to killianmuldoon/cluster-api that referenced this pull request Nov 19, 2021
…-contents

🐛 fix contents table  and header in scope and objectives
killianmuldoon pushed a commit to killianmuldoon/cluster-api that referenced this pull request Nov 19, 2021
…-contents

🐛 fix contents table  and header in scope and objectives
killianmuldoon pushed a commit to killianmuldoon/cluster-api that referenced this pull request Nov 19, 2021
…-contents

🐛 fix contents table  and header in scope and objectives
killianmuldoon pushed a commit to killianmuldoon/cluster-api that referenced this pull request Nov 19, 2021
…-contents

🐛 fix contents table  and header in scope and objectives
killianmuldoon pushed a commit to killianmuldoon/cluster-api that referenced this pull request Nov 19, 2021
…-contents

🐛 fix contents table  and header in scope and objectives
killianmuldoon pushed a commit to killianmuldoon/cluster-api that referenced this pull request Nov 19, 2021
…-contents

🐛 fix contents table  and header in scope and objectives
killianmuldoon pushed a commit to killianmuldoon/cluster-api that referenced this pull request Nov 19, 2021
…-contents

🐛 fix contents table  and header in scope and objectives
killianmuldoon pushed a commit to killianmuldoon/cluster-api that referenced this pull request Nov 19, 2021
…-contents

🐛 fix contents table  and header in scope and objectives
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants