-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃尡 tilt up: deploy provider CRDs and CRs #5712
馃尡 tilt up: deploy provider CRDs and CRs #5712
Conversation
cc4cc1d
to
4659a50
Compare
b18b00e
to
76f6a3f
Compare
@fabriziopandini Should be all fixed now. I also had to introduce a dependency from Provider CR=>CRD to avoid that the Provider CR deployment fails on startup. |
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
6b9c153
to
7d72c8b
Compare
@fabriziopandini squashed and verified that each provider tab only has the controller + binary section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5676