-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃尡 Add image promotion make target using kpromo #5713
馃尡 Add image promotion make target using kpromo #5713
Conversation
/assign @vincepri |
6fd107d
to
f95c041
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
one nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks @CecileRobertMichon !
f95c041
to
a806463
Compare
/lgtm |
Thanks for integrating the promotion tooling in Cluster API! 鉂わ笍 |
testing: /assign @kubernetes-sigs/cluster-api-maintainers |
/lgtm |
/lgtm |
@fabriziopandini absolutely, thank you for the review! |
@vincepri PTAL when you get a chance :) |
a806463
to
00fe0ce
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
00fe0ce
to
9374653
Compare
/lgtm |
@CecileRobertMichon ok to backport? |
we shouldn't need to backport, you can just use the main branch to run |
/cherry-pick release-0.4 |
@CecileRobertMichon: #5713 failed to apply on top of branch "release-0.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.0 |
@CecileRobertMichon: #5713 failed to apply on top of branch "release-1.0":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it: THIS WILL OPEN A PR FOR YOU IN k8s.io!! no more searching through the UI, copy pasting SHAs, all it takes is running "make promote-images" and voila! It will even assign the right people automatically 馃獎
This is based on some great work by @puerco + @palnabarun in krel and @justaugustus in kubernetes-sigs/promo-tools#458 鉂わ笍
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #