馃尡 Small improvements to ClusterClass validation messages #5744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
internal/topology/variables/clusterclass_variable_validation.go
Outdated
Show resolved
Hide resolved
internal/topology/variables/clusterclass_variable_validation.go
Outdated
Show resolved
Hide resolved
sbueringer
reviewed
Nov 29, 2021
sbueringer
reviewed
Nov 29, 2021
sbueringer
reviewed
Nov 29, 2021
internal/topology/variables/clusterclass_variable_validation.go
Outdated
Show resolved
Hide resolved
internal/topology/variables/clusterclass_variable_validation.go
Outdated
Show resolved
Hide resolved
sbueringer
reviewed
Nov 30, 2021
| @@ -178,9 +175,10 @@ func (webhook *ClusterClass) validateRemovedMachineDeploymentClassesAreNotUsed(c | |||
| for _, machineDeploymentTopology := range c.Spec.Topology.Workers.MachineDeployments { | |||
| if removedClasses.Has(machineDeploymentTopology.Class) { | |||
| // TODO(killianmuldoon): Improve error printing here so large scale changes don't flood the error log e.g. deduplication, only example usages given. | |||
| // TODO: consider if we get the index of the MachineDeploymentClass being deleted | |||
There was a problem hiding this comment.
I think that depends on if the path should apply to the old or new resource (or depending on the case one or the other)
sbueringer
reviewed
Nov 30, 2021
|
@killianmuldoon @sbueringer thanks for all the valuable comments. Now the PR should be ready for another round 馃槈 |
sbueringer
reviewed
Nov 30, 2021
fabriziopandini
force-pushed
the
small-improvements-to-clusterclass-validation-messages
branch
from
dc7524d
to
22d503e
Compare
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
fabriziopandini
deleted the
small-improvements-to-clusterclass-validation-messages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR contains a set of small improvements to ClusterClass validation messages.
While working on this, I also made consistent how we are calling validation func in unit tests.