馃悰 ClusterClass: fix nullable variables #5756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
sbueringer
force-pushed
the
pr-fix-nullable-variables
branch
from
33cd585
to
fd35be8
Compare
|
/assign @fabriziopandini @killianmuldoon |
sbueringer
force-pushed
the
pr-fix-nullable-variables
branch
from
fd35be8
to
8206cc9
Compare
|
/retest |
| @@ -892,7 +892,10 @@ spec: | |||
| instead of a custom JSON type, because controller-tools | |||
| has a hard-coded schema for apiextensionsv1.JSON which | |||
| cannot be produced by another type via controller-tools, | |||
| i.e. it''s not possible to have no type field. Ref: https://github.com/kubernetes-sigs/controller-tools/blob/d0e03a142d0ecdd5491593e941ee1d6b5d91dba6/pkg/crd/known_types.go#L106-L111' | |||
| i.e. it''s not possible to have no type field. Ref: https://github.com/kubernetes-sigs/controller-tools/blob/d0e03a142d0ecdd5491593e941ee1d6b5d91dba6/pkg/crd/known_types.go#L106-L111 | |||
There was a problem hiding this comment.
Suggested change
| i.e. it''s not possible to have no type field. Ref: https://github.com/kubernetes-sigs/controller-tools/blob/d0e03a142d0ecdd5491593e941ee1d6b5d91dba6/pkg/crd/known_types.go#L106-L111 | |
| i.e. it's not possible to have no type field. Ref: https://github.com/kubernetes-sigs/controller-tools/blob/d0e03a142d0ecdd5491593e941ee1d6b5d91dba6/pkg/crd/known_types.go#L106-L111 |
nit
There was a problem hiding this comment.
Seems to be the way controller-tools generates it, but I worked around it
|
One teeny nit from me. /lgtm |
k8s-ci-robot
added
the
lgtm
internal/topology/variables/cluster_variable_defaulting_test.go
Outdated
Show resolved
Hide resolved
sbueringer
force-pushed
the
pr-fix-nullable-variables
branch
from
8206cc9
to
bfc2e11
Compare
k8s-ci-robot
removed
the
lgtm
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-fix-nullable-variables
branch
from
bfc2e11
to
40af388
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
What this PR does / why we need it:
Before this PR it was not possible to actually use nullable variables by setting them to
null(in the YAML).This PR makes the
Valuefield nullable and makes sure the variable validation can handle itWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #