馃悰 ClusterClass: Fix defaulting of nullable variables #5773
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
sbueringer
force-pushed
the
pr-default-nullable-variables
branch
from
acd7a27
to
13ce1de
Compare
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-default-nullable-variables
branch
from
13ce1de
to
11c9eaf
Compare
| if err != nil { | ||
| return field.ErrorList{field.Invalid(fldPath, "", | ||
| fmt.Sprintf("failed defaulting variable %q: %v", clusterVariable.Name, err))} | ||
| // If the schema has a default value, default it. |
There was a problem hiding this comment.
Please note:
I dropped the usage of the structural lib for now, but I will re-introduce it with the support for object and arrays. It's just that with the bugfix for nullable variable we don't need it anymore for basic types.
And it's hard to explain how structural lib and this bugfix would work together without other corresponding changes which are needed for objects/arrays.
|
/assign @fabriziopandini @vincepri |
|
flake |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
What this PR does / why we need it:
This PR changes our defaulting code so it's also able to default nullable variables.
Split out of https://github.com/kubernetes-sigs/cluster-api/pull/5764/files
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #