Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 Use Kubernetes 1.23 in: quickstart, CAPD, e2e tests + update doc #5800

Merged
merged 1 commit into from
Dec 8, 2021
Merged

馃尡 Use Kubernetes 1.23 in: quickstart, CAPD, e2e tests + update doc #5800

merged 1 commit into from
Dec 8, 2021

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Dec 6, 2021 •
edited

Signed-off-by: Stefan B眉ringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Partially implements #5793

Related: kubernetes/test-infra#24554

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 6, 2021
@sbueringer
Copy link
Member Author

/hold
until Kubernetes 1.23 is released (probably tomorrow)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2021
@sbueringer sbueringer mentioned this pull request Dec 6, 2021
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2021
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

/test pull-cluster-api-test-mink8s-main

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Use Kubernetes 1.23 in: quickstart, CAPD, e2e tests + update doc
bd996d7 
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

sbueringer
sbueringer commented Dec 8, 2021
View reviewed changes
docs/book/src/user/quick-start.md
@@ -731,7 +731,7 @@ Calico is used here as an example.

```bash
kubectl --kubeconfig=./capi-quickstart.kubeconfig \
apply -f https://docs.projectcalico.org/v3.20/manifests/calico.yaml
apply -f https://docs.projectcalico.org/v3.21/manifests/calico.yaml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: I've verified the quickstart locally with Kubernetes 1.23 and Calico v3.21

@sbueringer
Copy link
Member Author

sbueringer commented Dec 8, 2021 •
edited

/hold cancel

Ready for review/merge

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2021
@sbueringer
Copy link
Member Author

/assign @fabriziopandini

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main
GitHub flake

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main
Another GitHub flake

fabriziopandini
fabriziopandini reviewed Dec 8, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking over this effort!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit dc4509f into kubernetes-sigs:main Dec 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Dec 8, 2021
@sbueringer sbueringer deleted the pr-kubernetes-1.23 branch December 8, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sbueringer @k8s-ci-robot @fabriziopandini