Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 clusterctl: fix typo for GitHub rate limit error #5801

Merged
merged 1 commit into from Dec 6, 2021
Merged

馃尡 clusterctl: fix typo for GitHub rate limit error #5801

merged 1 commit into from Dec 6, 2021

Conversation

damdo
Copy link
Member

@damdo damdo commented Dec 6, 2021

What this PR does / why we need it:
This PR fixes a typo in the GitHub rate limit text.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 6, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @damdo!

It looks like this is your first PR to kubernetes-sigs/cluster-api 馃帀. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 馃槂

@k8s-ci-robot
Copy link
Contributor

Hi @damdo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2021
@vincepri
Copy link
Member

vincepri commented Dec 6, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 6, 2021
@stmcginnis
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2021
killianmuldoon
killianmuldoon approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

sbueringer
sbueringer reviewed Dec 6, 2021
View reviewed changes
cmd/clusterctl/client/cluster/template.go Outdated
@@ -215,7 +215,7 @@ func getGitHubClient(configVariablesClient config.VariablesClient) (*github.Clie
// handleGithubErr wraps error messages.
func handleGithubErr(err error, message string, args ...interface{}) error {
if _, ok := err.(*github.RateLimitError); ok {
return errors.New("rate limit for github api has been reached. Please wait one hour or get a personal API tokens a assign it to the GITHUB_TOKEN environment variable")
return errors.New("rate limit for github api has been reached. Please wait one hour or get a personal API tokens and assign it to the GITHUB_TOKEN environment variable")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return errors.New("rate limit for github api has been reached. Please wait one hour or get a personal API tokens and assign it to the GITHUB_TOKEN environment variable")
return errors.New("rate limit for github api has been reached. Please wait one hour or get a personal API token and assign it to the GITHUB_TOKEN environment variable")

nit, same below

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, included.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2021
@damdo
Copy link
Member Author

damdo commented Dec 6, 2021

Included some new changes caught by @sbueringer. We'll need the lgtms again, @stmcginnis @killianmuldoon, thanks.

@stmcginnis
Copy link
Contributor

Good call...

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2021
@sbueringer
Copy link
Member

Thx!

@damdo Can you please squash the commits? (we're running Prow without squash to preserve information for our release note generation tool)

Otherwise lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2021
@damdo
Copy link
Member Author

damdo commented Dec 6, 2021

Done 馃憤 thanks for the guidance @sbueringer.

@sbueringer
Copy link
Member

You're welcome :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2021
fabriziopandini
fabriziopandini reviewed Dec 6, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damdo congrats on your first PR on CAPI! Welcome to the team!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit 65d65d2 into kubernetes-sigs:main Dec 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Dec 6, 2021
@damdo damdo deleted the clusterctl-client-ratelimit-error-typo branch December 6, 2021 23:20
@damdo damdo mentioned this pull request Feb 23, 2023
Closed
9 tasks
@damdo damdo mentioned this pull request Jun 12, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@stmcginnis stmcginnis

@sbueringer sbueringer

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@damdo @k8s-ci-robot @vincepri @stmcginnis @sbueringer @fabriziopandini @killianmuldoon