Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 CAPD: add ClusterClass cluster-template #5805

Merged

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Dec 6, 2021

Signed-off-by: Stefan B眉ringer buringerst@vmware.com

What this PR does / why we need it:
More context in the issue.

Tested manually against a tilt-managed cluster (envsubst'ed cluster-template manually + kubectl apply)

Note: The KCPTemplate is only valid after #5788 has been merged.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5730

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 6, 2021
@@ -78,6 +66,18 @@ spec:
---
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: DockerMachineTemplate
metadata:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just moved this down as it's the more logical order and to make it easy to diff against (and thus keep in sync with) the ClusterClass

Signed-off-by: Stefan B眉ringer buringerst@vmware.com
@sbueringer sbueringer changed the title CAPD: add ClusterClass cluster-template 馃尡 CAPD: add ClusterClass cluster-template Dec 6, 2021
@sbueringer
Copy link
Member Author

/assign @fabriziopandini

@fabriziopandini
Copy link
Member

/lgtm
/approve
Before release, we should check ClusterClass documentation overall and make sure this template is documented somewhere (might be in the main quick start, so it is possible to drop the custom one under https://cluster-api.sigs.k8s.io/tasks/experimental-features/cluster-classes.html)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8107eae into kubernetes-sigs:main Dec 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Dec 8, 2021
@sbueringer sbueringer deleted the pr-capd-cluster-template branch December 8, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish CAPD cluster-template with ClusterClass
3 participants