馃悰 Fix incorrect array initalization causing incorrect webhook failures #5808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
sbueringer
reviewed
Dec 7, 2021
| @@ -197,7 +197,7 @@ func validateVariableUpdates(clusters []clusterv1.Cluster, old, new *clusterv1.C | |||
| varsDiff := getClusterClassVariablesForValidation(oldVars, newVars) | |||
|
|
|||
| errorInfo := errorAggregator{} | |||
| allClusters := make([]string, len(clusters)) | |||
| allClusters := []string{} | |||
There was a problem hiding this comment.
NOTE: with 1 cluster this resulted in: allClusters: []string{""} which was then further appended and eventually lead to an error
|
/test pull-cluster-api-e2e-main /lgtm P.S. Fixup PR for test-infra to trigger jobs correctly: kubernetes/test-infra#24567 |
k8s-ci-robot
added
the
lgtm
| @@ -1814,6 +1814,74 @@ func TestClusterClassValidationWithVariableChecks(t *testing.T) { | |||
| Build(), | |||
| expectErr: true, | |||
| }, | |||
| { | |||
| name: "Pass if a non-variable update is made to a ClusterClass with required variables.", | |||
There was a problem hiding this comment.
Suggested change
| name: "Pass if a non-variable update is made to a ClusterClass with required variables.", | |
| name: "Pass if an update is made to a ClusterClass with required variables, but with no changes to variables", |
killianmuldoon
force-pushed
the
fix/required-variable-validation
branch
from
634a586
to
e226239
Compare
k8s-ci-robot
removed
the
lgtm
killianmuldoon
force-pushed
the
fix/required-variable-validation
branch
from
e226239
to
fd0f35b
Compare
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
killianmuldoon
force-pushed
the
fix/required-variable-validation
branch
from
fd0f35b
to
43165ae
Compare
|
/test pull-cluster-api-e2e-main /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: killianmuldoon kmuldoon@vmware.com
This fixes an issue where non-variable related updates on ClusterClasses are rejected due to incorrect initialisation of an array for checking variables.
/cc @sbueringer