馃悰 Fix cluster topology and UpdateCoreDNS test flakes #5815
Conversation
Signed-off-by: Stefan B眉ringer buringerst@vmware.com Co-authored-by: killianmuldoon <kmuldoon@vmware.com> Co-authored-by: Yuvaraj Kakaraparthi <kakaraparthy@vmware.com>
k8s-ci-robot
added
cncf-cla: yes
| @@ -547,7 +547,7 @@ func setupTestEnvForIntegrationTests(ns *corev1.Namespace) (func() error, error) | |||
| cleanup := func() error { | |||
| // Delete Objects in reverse, because we cannot delete a ClusterCLass if it is still used by a Cluster. | |||
| for i := len(initObjs) - 1; i >= 0; i-- { | |||
| if err := env.Delete(ctx, initObjs[i]); err != nil { | |||
| if err := env.CleanupAndWait(ctx, initObjs[i]); err != nil { | |||
There was a problem hiding this comment.
Sometimes the Cluster was not gone in the local cache and then the subsequent ClusterClass deletion failed (because the webhook blocked the ClusterClass deletion)
| g.Expect(expectedKubeadmConfigMap.Data).To(HaveKeyWithValue("ClusterConfiguration", ContainSubstring(tt.kcp.Spec.KubeadmConfigSpec.ClusterConfiguration.DNS.ImageTag))) | ||
| g.Expect(expectedKubeadmConfigMap.Data).To(HaveKeyWithValue("ClusterConfiguration", ContainSubstring(tt.kcp.Spec.KubeadmConfigSpec.ClusterConfiguration.DNS.ImageRepository))) | ||
| return nil | ||
| }, "5s").Should(Succeed()) |
There was a problem hiding this comment.
Sometimes the local cache was stale, so the test still checked the old version of the ConfigMap
|
/cc @killianmuldoon @ykakarap /assign @fabriziopandini |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
Co-authored-by: killianmuldoon kmuldoon@vmware.com
Co-authored-by: Yuvaraj Kakaraparthi kakaraparthy@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #