Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Add v1.1 to metadata.yaml #5819

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

sbueringer
Copy link
Member

What this PR does / why we need it:
This PR adds the upcoming v1.1 release series to the metadata.yaml

I tried to deploy providers via the local repository (generated via cmd/clusterctl/hack/create-local-repository.py which is using the top-level ./metadata.yaml)
and it failed because the release series was missing:

./bin/clusterctl init --core cluster-api:v1.1.99 --bootstrap kubeadm:v1.1.99 --control-plane kubeadm:v1.1.99 --infrastructure docker:v1.1.99 --config ~/.cluster-api/dev-repository/config.yaml
Fetching providers
Error: invalid provider metadata: version v1.1.99 for the provider capi-system/cluster-api does not match any release series

I think we have to add it before the release anyway.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 8, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 8, 2021
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 8, 2021
@sbueringer
Copy link
Member Author

/assign @fabriziopandini

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 891f585 into kubernetes-sigs:main Dec 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Dec 8, 2021
@sbueringer sbueringer deleted the pr-fix-metadata-yaml branch December 8, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants