🌱 modify providerid struct string method to receive value

[DiptoChakrabarty]

🌱

What this PR does / why we need it:
This modifies the String method which implements the Stringer interface to receive value instead of pointers

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5755 (working on)

If this seems correct would like to modify the other ones as well

[k8s-ci-robot]

Hi @DiptoChakrabarty. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

/ok-to-test

Change itself looks good to me. I just can't say if we have a problem with our API stability guarantees (as stated in the issue).

/cc @CecileRobertMichon @enxebre @fabriziopandini @vincepri

[enxebre]

Thanks, TIL. I don't think this is breaking given https://go.dev/doc/effective_go#pointers_vs_values

The rule about pointers vs. values for receivers is that value methods can be invoked on pointers and values, but pointer methods can only be invoked on pointers.

/lgtm

[CecileRobertMichon]

/lgtm

[sbueringer]

There's a parallel discussion in #5755 (comment)
Let's see what the outcome of this is before we merge this PR

[vincepri]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment