-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃尡 ClusterClass: add documentation fields for patches and variables #5825
馃尡 ClusterClass: add documentation fields for patches and variables #5825
Conversation
@@ -261,6 +267,9 @@ type ClusterClassPatch struct { | |||
// Name of the patch. | |||
Name string `json:"name"` | |||
|
|||
// Description is a human-readable description of this patch. | |||
Description string `json:"description,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only added it top-level for now. I'm not sure if we really need it on PatchDefinition and JSONPatch
/assign @fabriziopandini @vincepri |
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
d9071cf
to
2212968
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
What this PR does / why we need it:
Adds documentation fields which will make it easier for ClusterClass authors to document ClusterClasses.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5649