馃尡 added variable example and description to clusterclass yamls #5842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
killianmuldoon
force-pushed
the
add-variable-descriptions
branch
2 times, most recently
from
845bf4a
to
9e2a3a6
Compare
killianmuldoon
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
sbueringer
reviewed
Dec 9, 2021
test/e2e/data/infrastructure-docker/v1beta1/clusterclass-quick-start.yaml
Outdated
Show resolved
Hide resolved
test/e2e/data/infrastructure-docker/v1beta1/clusterclass-quick-start.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
killianmuldoon
force-pushed
the
add-variable-descriptions
branch
from
9e2a3a6
to
dcc7565
Compare
k8s-ci-robot
removed
the
lgtm
|
Thx! |
k8s-ci-robot
added
the
lgtm
killianmuldoon
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: killianmuldoon kmuldoon@vmware.com
Add variable examples and description and patch descriptions to the files used in the ClusterClass quickstart end to end tests and the clusterclass-quick-start.yaml docker template.