馃尡 Enable more gocritic lint checks #5843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/retest |
stmcginnis
force-pushed
the
ioutil-lint
branch
from
7dcdb60
to
2649c36
Compare
sbueringer
reviewed
Dec 10, 2021
controllers/topology/internal/extensions/patches/inline/json_patch_generator.go
Outdated
Show resolved
Hide resolved
sbueringer
reviewed
Dec 10, 2021
invidian
reviewed
Dec 10, 2021
test/infrastructure/docker/internal/provisioning/ignition/kindadapter.go
Show resolved
Hide resolved
There are a multiple groups of checks run by gocritic. Some are enabled by default, but others require explicit enabling. This enables the experimental group, minus a few exceptions that would either be too disruptive or are things we aren't concerned about. One of the main benefits of this extra coverage is the flagging of using the deprecated ioutil package. Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
stmcginnis
force-pushed
the
ioutil-lint
branch
from
2649c36
to
88ddd8a
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There are a multiple groups of checks run by gocritic. Some are enabled
by default, but others require explicit enabling. This enables the
experimental group, minus a few exceptions that would either be too
disruptive or are things we aren't concerned about.
One of the main benefits of this extra coverage is the flagging of using
the deprecated ioutil package.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #4419