Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 ClusterClass: Add reconcile repeatedly test #5846

Merged
merged 1 commit into from
Jan 14, 2022
Merged

🌱 ClusterClass: Add reconcile repeatedly test #5846

merged 1 commit into from
Jan 14, 2022

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Dec 10, 2021 •
edited

What this PR does / why we need it:
This PR adds a test which runs multiple reconciles and thus validates if a sequence of reconciles behave as expected. The most important behavior we're verifying that way is the handling of managed-field-paths.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 10, 2021
@sbueringer sbueringer force-pushed the pr-topology-managed-fields-more-tests branch 6 times, most recently from c9208e6 to 1e872a4 Compare December 10, 2021 17:06
@sbueringer sbueringer mentioned this pull request Dec 10, 2021
Merged
@sbueringer sbueringer force-pushed the pr-topology-managed-fields-more-tests branch 2 times, most recently from 28d4e5d to 0cdd7ef Compare December 10, 2021 19:11
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2021
@sbueringer sbueringer force-pushed the pr-topology-managed-fields-more-tests branch from 0cdd7ef to 6c6a5ca Compare January 5, 2022 15:34
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 5, 2022
@sbueringer sbueringer force-pushed the pr-topology-managed-fields-more-tests branch from 6c6a5ca to 54ad34a Compare January 5, 2022 15:36
@sbueringer sbueringer changed the title [WIP] ClusterClass: Add reconcile repeatedly test 🌱 ClusterClass: Add reconcile repeatedly test Jan 5, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2022
@sbueringer sbueringer force-pushed the pr-topology-managed-fields-more-tests branch from 54ad34a to 819918c Compare January 5, 2022 15:50
@sbueringer
Copy link
Member Author

/assign @fabriziopandini

Should be ready for review know.

(btw, +/- the annotation name the tests still worked without any further modifications)

@sbueringer
Copy link
Member Author

/test pull-cluster-api-verify-main

1 similar comment
@sbueringer
Copy link
Member Author

/test pull-cluster-api-verify-main

vincepri
vincepri approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sbueringer
Copy link
Member Author

/retest

@sbueringer sbueringer force-pushed the pr-topology-managed-fields-more-tests branch from 50169aa to 78b7ced Compare January 11, 2022 15:01
@sbueringer
Copy link
Member Author

I'll adjust the PR to the latest changes.

@sbueringer
Copy link
Member Author

lgtm from my side for Fabrizio's changes.

@sbueringer sbueringer force-pushed the pr-topology-managed-fields-more-tests branch from 3f11c71 to d1763fd Compare January 13, 2022 12:55
@sbueringer
Copy link
Member Author

Squashed
@fabriziopandini @vincepri ptal

@fabriziopandini
Copy link
Member

/lgtm
@vincepri PTAL

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 13, 2022
@sbueringer sbueringer force-pushed the pr-topology-managed-fields-more-tests branch from d1763fd to 501a7d7 Compare January 14, 2022 11:54
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 14, 2022
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-workload-upgrade-1-23-latest-main
(just want to test if it works, it wasn't run in a long time and we fixed the corresponding periodic recently)

vincepri
vincepri approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2022
@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 14, 2022
@sbueringer @fabriziopandini
ClusterClass: Add reconcile repeatedly test
62fa051 
Signed-off-by: Stefan Büringer buringerst@vmware.com

Co-authored-by: fabriziopandini <fpandini@vmware.com>
@sbueringer sbueringer force-pushed the pr-topology-managed-fields-more-tests branch from 501a7d7 to 62fa051 Compare January 14, 2022 16:52
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 14, 2022
@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 58f834f into kubernetes-sigs:main Jan 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Jan 14, 2022
@sbueringer sbueringer deleted the pr-topology-managed-fields-more-tests branch January 14, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@vincepri vincepri

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sbueringer @fabriziopandini @k8s-ci-robot @vincepri