Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰update docker and containerd deps #5878

Merged

Conversation

mkumatag
Copy link
Member

What this PR does / why we need it:

There are few medium to low vulnerabilities were detected whoever using this module, hence these deps needs to be updated to the latest available version.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 20, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 20, 2021
@mkumatag mkumatag changed the title update docker and containerd deps 馃悰update docker and containerd deps Dec 20, 2021
@JoelSpeed
Copy link
Contributor

/lgtm

Seems reasonable given the vulnerabilities, thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2021
@fabriziopandini
Copy link
Member

/lgtm

/test pull-cluster-api-e2e-full-main

@mkumatag
Copy link
Member Author

/lgtm

/test pull-cluster-api-e2e-full-main

Test passed.

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit 633ddc0 into kubernetes-sigs:main Dec 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Dec 21, 2021
@mkumatag mkumatag deleted the update_docker_containerd branch December 24, 2021 05:18
@mkumatag
Copy link
Member Author

/cherry-pick release-1.0

@k8s-infra-cherrypick-robot

@mkumatag: #5878 failed to apply on top of branch "release-1.0":

Applying: update docker and containerd deps
Using index info to reconstruct a base tree...
M	hack/tools/go.sum
M	test/go.mod
M	test/go.sum
Falling back to patching base and 3-way merge...
Auto-merging test/go.sum
Auto-merging test/go.mod
Auto-merging hack/tools/go.sum
CONFLICT (content): Merge conflict in hack/tools/go.sum
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 update docker and containerd deps
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants