-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 kcp: make KubeadmConfig format mutable #5904
馃悰 kcp: make KubeadmConfig format mutable #5904
Conversation
/test ? |
@sbueringer: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-e2e-full-main /assign @fabriziopandini |
cd74689
to
896bd73
Compare
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
896bd73
to
66bdecf
Compare
/test pull-cluster-api-e2e-full-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-cluster-api-e2e-workload-upgrade-1-23-latest-main |
@sbueringer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
What this PR does / why we need it:
Currently the KubeadmConfig format in KCP is immutable. This means that KCP objects created with older versions of CAPI cannot be adopted (because any update on KCP would automatically try to set the format to "cloud-config" which is then blocked because a mutation from "" to "cloud-config" is forbidden).
Thus this PR suggests to make the format mutable. I think it's fine to do that as I don't see a reason why it shouldn't be possible to change the format.
Note: also includes a minor improvement to the e2e test logs which was done when debugging this issue.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #