-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃尡 Move internal test packages into internal/test #5930
馃尡 Move internal test packages into internal/test #5930
Conversation
aae8224
to
642cb6e
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
/approve |
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
642cb6e
to
c014ed1
Compare
@fabriziopandini rebased |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
What this PR does / why we need it:
I think now that we've moved a few more packages into internal/ it makes sense to group the test packages together in
internal/test
.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Found in the context of #5455