🐛 Fix to improper formatting of UnhealthyRange #5932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
sbueringer
reviewed
Jan 13, 2022
internal/controllers/machinehealthcheck/machinehealthcheck_controller.go
Outdated
Show resolved
Hide resolved
killianmuldoon
force-pushed
the
fix/unhealthy-range-format
branch
from
ec2497d
to
b490b3c
Compare
k8s-ci-robot
added
size/XS
killianmuldoon
force-pushed
the
fix/unhealthy-range-format
branch
2 times, most recently
from
e3caf1a
to
c5cc5e5
Compare
k8s-ci-robot
added
size/S
killianmuldoon
force-pushed
the
fix/unhealthy-range-format
branch
from
c5cc5e5
to
701af5e
Compare
sbueringer
reviewed
Jan 13, 2022
internal/controllers/machinehealthcheck/machinehealthcheck_controller.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinehealthcheck/machinehealthcheck_controller.go
Outdated
Show resolved
Hide resolved
killianmuldoon
force-pushed
the
fix/unhealthy-range-format
branch
from
701af5e
to
e177f89
Compare
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
killianmuldoon
force-pushed
the
fix/unhealthy-range-format
branch
from
e177f89
to
ee2a818
Compare
k8s-ci-robot
added
size/XS
|
Nice, one character change :D /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
sbueringer
pushed a commit
to sbueringer/cluster-api
that referenced
this pull request
Jan 20, 2022
…lthy-range-format 🐛 Fix to improper formatting of UnhealthyRange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: killianmuldoon kmuldoon@vmware.com
This change adds formatting to a condition and event in the machineHealthCheck controller that handles the percentage sign included in the message.
Previously this message would print as:
Remediation is not allowed, the number of not started or unhealthy machines exceeds maxUnhealthy (total: 1, unhealthy: 0, maxUnhealthy: 45%!)(MISSING)Due to the percentage sign being included in the unhealthyRange string. There's an example here: https://go.dev/play/p/mX6DG6oRzKW