-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃摉 Add steps to resolve Docker Desktop inotify limit issues #5947
馃摉 Add steps to resolve Docker Desktop inotify limit issues #5947
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
f9488d1
to
dd22173
Compare
/lgtm |
+1 on merging this for now, could we also open an issue in Docker for Mac directly to notify the maintainers about this potential regression? |
docker/for-mac#6071 There's an issue open here. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: killianmuldoon kmuldoon@vmware.com
This PR adds steps to set inotify limits inside the VM running as part of Docker Desktop. In Docker's 4.3 update a number of errors with the message "too many open files" prevented more than a single digit number of containers being run on a host.
Changing the inotify limits as described here in the Docker VM will resolve the issue. I don't think we should close the issue with this change as it would be better to find out if Docker can have these limits set by default.
Addresses #5940
/kind documentation