Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 book: add API conversion code walkthrough video #5958

Merged
merged 1 commit into from
Jan 20, 2022
Merged

馃尡 book: add API conversion code walkthrough video #5958

merged 1 commit into from
Jan 20, 2022

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jan 20, 2022 •
edited

Signed-off-by: Stefan B眉ringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5289

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2022
@sbueringer
Copy link
Member Author

/cc @fabriziopandini

@sbueringer
book: add API conversion code walkthrough video
b661496 
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
@sbueringer
Copy link
Member Author

@killianmuldoon just fyi, there's another occurrence of the object mover flake: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/5958/pull-cluster-api-test-main/1484083624197230592

/retest

@sbueringer
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2022
killianmuldoon
killianmuldoon approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

If we're going to be adding a number of these should we think about getting a core Youtube channel to host them on? Personal Youtube channels might become a problem to maintain over time.

@sbueringer
Copy link
Member Author

sbueringer commented Jan 20, 2022 •
edited

/lgtm

If we're going to be adding a number of these should we think about getting a core Youtube channel to host them on? Personal Youtube channels might become a problem to maintain over time.

According to the meeting notes it's recommended to upload the videos with the personal YouTube account and then add it to the Sig Cluster Lifecycle playlist (https://docs.google.com/document/d/1ushaVqAKYnZ2VN_aa3GyKlS4kEd6bSug13xaXOakAQI/edit#heading=h.pxsq37pzkbdq). Which was done in this case. (I just aligned to what we're doing with the office hours)

I don't have any background information why it's done like this and if there are alternatives.

@sbueringer
Copy link
Member Author

sbueringer commented Jan 20, 2022 •
edited

Fixes #5289
(Yup, has to be in the PR description)

fabriziopandini
fabriziopandini reviewed Jan 20, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃コ
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit f7d30f4 into kubernetes-sigs:main Jan 20, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Jan 20, 2022
@sbueringer sbueringer deleted the pr-add-conv-vid branch January 21, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

Create step-by-step guide for implementing conversion webhooks in CAPI
4 participants
@sbueringer @k8s-ci-robot @fabriziopandini @killianmuldoon