Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix cert manager repo and add troubleshooting guide #6052

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #6050

/assign fabriziopandini

Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Feb 2, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 2, 2022
@k8s-ci-robot
Copy link
Contributor

@k8s-infra-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-release-1-1 7efd2b9 link false /test pull-cluster-api-apidiff-release-1-1

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fabriziopandini fabriziopandini changed the title [release-1.1] 馃悰 Fix cert manager repo and add troubleshooting guide 馃悰 Fix cert manager repo and add troubleshooting guide Feb 2, 2022
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2022
@fabriziopandini
Copy link
Member

/lgtm
/approve
/cherry-pick release-1.0

@k8s-infra-cherrypick-robot
Copy link
Author

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you.

In response to this:

/lgtm
/approve
/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit e2aafb6 into kubernetes-sigs:release-1.1 Feb 2, 2022
@k8s-infra-cherrypick-robot
Copy link
Author

@fabriziopandini: #6052 failed to apply on top of branch "release-1.0":

Applying: Fix cert manager repo and add troubleshooting guide
.git/rebase-apply/patch:51: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	docs/book/src/user/troubleshooting.md
Falling back to patching base and 3-way merge...
Auto-merging docs/book/src/user/troubleshooting.md
CONFLICT (content): Merge conflict in docs/book/src/user/troubleshooting.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix cert manager repo and add troubleshooting guide
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/lgtm
/approve
/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

garloff added a commit to SovereignCloudStack/k8s-cluster-api-provider that referenced this pull request Feb 3, 2022
cert-manager has moved upstream. capi-1.0.2/1.0.3 would fail
to deploy because of this. See
kubernetes-sigs/cluster-api#6052

Signed-off-by: Kurt Garloff <kurt@garloff.de>
garloff added a commit to SovereignCloudStack/k8s-cluster-api-provider that referenced this pull request Feb 3, 2022
* Upgrade to capi v1.0.4 to fix cert-manager.

cert-manager has moved upstream. capi-1.0.2/1.0.3 would fail
to deploy because of this. See
kubernetes-sigs/cluster-api#6052

* Also fix (optional) cert-manager deployment into cluster.

* Also fix cmctl download.

Signed-off-by: Kurt Garloff <kurt@garloff.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants