馃悰 SSA: create cluster-shim with regular client, use ignorePaths on create #6914
Conversation
k8s-ci-robot
added
cncf-cla: yes
| // Given that the cluster shim is a temporary object which is only modified | ||
| // by this controller, it is not necessary to use the SSA patch helper. |
There was a problem hiding this comment.
Did a bit of testing with Fabrizio and we think that it would be just simpler to use the regular client here (as documented in the godoc comment)
Co-authored-by: fabriziopandini <fpandini@vmware.com>
sbueringer
force-pushed
the
pr-minor-fixes
branch
from
0207edc
to
0b48593
Compare
|
/test pull-cluster-api-e2e-full-main |
|
/cherry-pick release-1.2 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@sbueringer: new pull request created: #6915 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: fabriziopandini fpandini@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #