[clusterctl] Fix create cluster workflow #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes kubernetes-sigs#697 Signed-off-by: Chuck Ha <chuckh@vmware.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
pushed a commit
to kubernetes-sigs/cluster-api-provider-openstack
that referenced
this pull request
Jan 23, 2019
Current version of cluster-api contains issue fixed in upstream here: kubernetes-sigs/cluster-api#698. That issue prevents clusterctl bootstrap arguments from working. Also this update brings kind bootstrapper which is nice. Change-Id: I2ff60e2a6d2adb9a735a9bb9c0aed181cb6ce475
flaper87
pushed a commit
to flaper87/cluster-api-provider-openstack
that referenced
this pull request
Jan 28, 2019
Current version of cluster-api contains issue fixed in upstream here: kubernetes-sigs/cluster-api#698. That issue prevents clusterctl bootstrap arguments from working. Also this update brings kind bootstrapper which is nice. Change-Id: I2ff60e2a6d2adb9a735a9bb9c0aed181cb6ce475
eromanova
pushed a commit
to eromanova/cluster-api-provider-openstack
that referenced
this pull request
Feb 12, 2019
* adjust mirantis-specific parts to new code * fix master config substitution (we got `/` in base64 output) * backport kubernetes-sigs/cluster-api#698 to make clusterctl work (directly in vendor/ dir, should be ok?) * fix default cloud usage when cloudsSecret is absent in machine's provider config Change-Id: I7520c5827510f7259457d8d6749d5242cbfa1b55
eromanova
pushed a commit
to eromanova/cluster-api-provider-openstack
that referenced
this pull request
Feb 12, 2019
Current version of cluster-api contains issue fixed in upstream here: kubernetes-sigs/cluster-api#698. That issue prevents clusterctl bootstrap arguments from working. Also this update brings kind bootstrapper which is nice. Change-Id: I836f5e6a693ae377497f34ff266b77ec0cd67a7d Reviewed-on: http://gerrit.mcp.mirantis.com/34257 Tested-by: <mcp-jenkins@mirantis.com> Reviewed-by: Yuriy Taraday <ytaraday@mirantis.com> Workflow: Yuriy Taraday <ytaraday@mirantis.com>
pierreprinetti
pushed a commit
to shiftstack/cluster-api-provider-openstack
that referenced
this pull request
Apr 22, 2024
Current version of cluster-api contains issue fixed in upstream here: kubernetes-sigs/cluster-api#698. That issue prevents clusterctl bootstrap arguments from working. Also this update brings kind bootstrapper which is nice. Change-Id: I2ff60e2a6d2adb9a735a9bb9c0aed181cb6ce475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes a minor typo to fix the
clusterctl createworkflowSpecial notes for your reviewer:
This has been tested at least by hand using the cluster-api-provider-aws
Release note:
/assign @vincepri