Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Update conversion-gen version (v0.23.1 -> v0.25.0) #7118

Merged
merged 1 commit into from
Aug 25, 2022
Merged

🌱 Update conversion-gen version (v0.23.1 -> v0.25.0) #7118

merged 1 commit into from
Aug 25, 2022

Conversation

oscr
Copy link
Contributor

@oscr oscr commented Aug 24, 2022

What this PR does / why we need it:

Update conversion-gen version (v0.23.1 -> v0.25.0).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #6661

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 24, 2022
ykakarap
ykakarap reviewed Aug 25, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2022
@chrischdi
Copy link
Member

/lgtm

killianmuldoon
killianmuldoon approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fabriziopandini
Copy link
Member

/lgtm

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit 79efaff into kubernetes-sigs:main Aug 25, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Aug 25, 2022
@sbueringer sbueringer mentioned this pull request Aug 25, 2022
Closed
29 tasks
@oscr oscr deleted the bump-conversion-gen branch August 25, 2022 13:57
This was referenced Nov 18, 2022
Closed
Closed
@ykakarap ykakarap mentioned this pull request Nov 30, 2022
Closed
13 tasks
@joekr joekr mentioned this pull request Apr 3, 2023
Closed
12 tasks
@ykakarap ykakarap mentioned this pull request May 20, 2023
Closed
13 tasks
@killianmuldoon killianmuldoon mentioned this pull request Oct 19, 2023
Closed
14 tasks
@sbueringer sbueringer mentioned this pull request Jan 19, 2024
Closed
13 tasks
@sbueringer sbueringer mentioned this pull request May 21, 2024
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykakarap ykakarap ykakarap left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@chrischdi chrischdi

@fabriziopandini fabriziopandini

@ykakarap ykakarap

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@oscr @chrischdi @fabriziopandini @sbueringer @k8s-ci-robot @ykakarap @killianmuldoon