馃尡 logging: adjust reconcilers to log object owners #7152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
sbueringer
commented
Sep 1, 2022
sbueringer
force-pushed
the
pr-finalize-log-hierarchy
branch
from
cb7acf5
to
6aa7be2
Compare
sbueringer
force-pushed
the
pr-finalize-log-hierarchy
branch
2 times, most recently
from
6f75ccd
to
aa5c779
Compare
|
Pushed unit tests and documented the new func in the migration doc. |
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-finalize-log-hierarchy
branch
from
aa5c779
to
934bc6b
Compare
|
Updated the note in the migration doc, renamed the func and added godoc. (I dropped the func from DockerMachinePool as I noticed that we don't need it there) |
sbueringer
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
What this PR does / why we need it:
With this PR we're logging all relevant k/v pairs for all our resources.
This PR also contains 1-2 smaller other logging fixes and an improvement to our Tiltfile so the ServiceAccount of Grafana is always deployed before the Grafana deployment.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #