Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.2] ✨add kubekey k3s boostrap and control plane provider #7553

Merged
merged 1 commit into from Nov 17, 2022
Merged

[release-1.2] ✨add kubekey k3s boostrap and control plane provider #7553

merged 1 commit into from Nov 17, 2022

Conversation

24sama
Copy link
Contributor

@24sama 24sama commented Nov 17, 2022 •
edited

What this PR does / why we need it:
add kubekey k3s boostrap and control plane provider. It's a manual check-pick PR for #7528

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 17, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @24sama. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 17, 2022
@24sama 24sama changed the title [release-1.2] add kubekey k3s boostrap and control plane provider [release-1.2] ✨add kubekey k3s boostrap and control plane provider Nov 17, 2022
@sbueringer
Copy link
Member

@24sama Can you please open a cherry-pick PR for v1.3 as well? (release-1.3 branch was created on Tuesday)

We prefer to merge in order main, release-1.3, ...

@24sama
Copy link
Contributor Author

24sama commented Nov 17, 2022 •
edited

Thanks for the review.
@sbueringer I guess you can call the bot to create a chery-pick pr on #7528

sbueringer
sbueringer reviewed Nov 17, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two nits

/ok-to-test

cmd/clusterctl/client/config_test.go Show resolved Hide resolved
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 17, 2022
@sbueringer
Copy link
Member

sbueringer commented Nov 17, 2022 •
edited

Thanks for the review. @sbueringer I guess you can call the bot to create a chery-pick pr on #7528

Good point :)

Done > #7554

@24sama
add kubekey k3s boostrap and control plane provider
16ef05a 
Signed-off-by: 24sama <jacksama@foxmail.com>
@24sama
Copy link
Contributor Author

24sama commented Nov 17, 2022

/retest

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2022
@sbueringer
Copy link
Member

Thx!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3e9ca33 into kubernetes-sigs:release-1.2 Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@24sama @k8s-ci-robot @sbueringer @fabriziopandini