Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Fix links in 0.3->0.4 migration guide #8508

Merged
merged 1 commit into from
Apr 11, 2023
Merged

📖 Fix links in 0.3->0.4 migration guide #8508

merged 1 commit into from
Apr 11, 2023

Conversation

killianmuldoon
Copy link
Contributor

Fix broken links found in the weekly markdown link scan.

/kind documentation

@killianmuldoon
Fix links in 0.3->0.4 migration guide
92a7faf 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2023
fabriziopandini
fabriziopandini reviewed Apr 11, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d51a2c07c3ff6a1f9661958fd6980853db661bdb

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit c49bfeb into kubernetes-sigs:main Apr 11, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Apr 11, 2023
@fabriziopandini
Copy link
Member

@killianmuldoon does this apply to the older versions as well?

Side idea; checking these jobs and sending patches is something that can be easily documented ad used as a first step to improve involvement of a broader set of contributors, starting from the release team. opinions?

@killianmuldoon
Copy link
Contributor Author

Good idea to make this explicitly part of the release team jobs - I'll add it to the release team tasks.

These links are only broken on main, so not relevant for other branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@killianmuldoon @k8s-ci-robot @fabriziopandini