🐛 Use CreateAndWait in MP ScaleFromZero test #8927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
sbueringer
reviewed
Jun 27, 2023
k8s-ci-robot
added
the
do-not-merge/hold
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
killianmuldoon
force-pushed
the
pr-mp-eventually-reconcile
branch
from
5ee0bf4
to
8cc18be
Compare
|
/retitle 🐛 Use CreateAndWait in MP ScaleFromZero test |
k8s-ci-robot
changed the title
|
/hold cancel Test green for me with ~30K runs on my machine. I caught the flake in action and it seems like it was down to the node not being available when reconcile was called. |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 7d95ba733015718d3919a84db494ecd48a71629b
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an eventually to the test
Should delete retired nodes when scaled to zerofor the MachinePool reconciler. This started flaking recently, likely due to changes in the use of the clusterCacheTracker in this reconciler.