Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱Remove k8s.io/utils/pointer from repository #9836

Merged

Conversation

troy0820
Copy link
Member

@troy0820 troy0820 commented Dec 8, 2023

What this PR does / why we need it:
There was a PR that removed most of these references but left them in the test cases. This PR removes the left over references and removes them from the _test.go files

/kind cleanup

  • Remove k8s.io/utils/pointer from repository
  • Replaced removed pointer with k8s.io/utils/ptr

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes the rest of this PR #7396

Notes for reviewers:

Sorry this PR is so large but most of this was replacing pointer -> ptr

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 8, 2023
@troy0820 troy0820 force-pushed the troy0820/replace-pointer-with-ptr branch 2 times, most recently from e2885c6 to 6e353af Compare December 8, 2023 21:07
@troy0820
Copy link
Member Author

troy0820 commented Dec 11, 2023

/area testing

@k8s-ci-robot k8s-ci-robot added the area/testing Issues or PRs related to testing label Dec 11, 2023
@k8s-ci-robot
Copy link
Contributor

@troy0820: The label(s) area/utils cannot be applied, because the repository doesn't have them.

In response to this:

/area testing
/area utils

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/needs-area PR is missing an area label labels Dec 11, 2023
@sbueringer
Copy link
Member

@troy0820 Can you please rebase the PR?
I'm waiting with review until after the rebase. Just want to avoid having to review it twice :)

Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
@troy0820 troy0820 force-pushed the troy0820/replace-pointer-with-ptr branch from 6e353af to b30d12b Compare December 12, 2023 14:45
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2023
@sbueringer
Copy link
Member

Thank you very much!!

Couldn't find anything :)

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d46f6c0f23242589111b566e958bf0e2a47c0220

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 72e5bc9 into kubernetes-sigs:main Dec 12, 2023
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants