Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 Small improvements to tilt #9936

Merged
merged 3 commits into from
Jan 8, 2024
Merged

馃尡 Small improvements to tilt #9936

merged 3 commits into from
Jan 8, 2024

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Small improvement to tilt

  • rename "kustomize_config" to a more explicit "apply_provider_yaml"
  • add support for defining a "kustomize_folder" (defaults config/default)
  • add support for defining "kustomize_options", e.g. "kustomize_options": "--load-restrictor=LoadRestrictionsNone"
  • automatically scale down deployments to 1 + remove resource limits/requests when activating the debugger

/area devtools

@k8s-ci-robot k8s-ci-robot added area/devtools Issues or PRs related to devtools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 28, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 28, 2023
chrischdi
chrischdi reviewed Dec 29, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f8dc11edf7edbdbf12eb3d12662f5db6a7f1e8b8

sbueringer
sbueringer reviewed Jan 2, 2024
View reviewed changes
docs/book/src/developer/tilt.md Outdated Show resolved Hide resolved
docs/book/src/developer/tilt.md Outdated Show resolved Hide resolved
docs/book/src/developer/tilt.md Outdated Show resolved Hide resolved
hack/tools/internal/tilt-prepare/main.go Outdated Show resolved Hide resolved
hack/tools/internal/tilt-prepare/main.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024
sbueringer
sbueringer reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remaining nit/question

docs/book/src/developer/tilt.md Outdated Show resolved Hide resolved
@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 8, 2024
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1dad56023ca8460fc11910848a3df5bbe40a7fb5

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 04cdfa6 into kubernetes-sigs:main Jan 8, 2024
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Jan 8, 2024
@fabriziopandini fabriziopandini deleted the small-improvements-to-tilt branch January 8, 2024 19:34
@fabriziopandini fabriziopandini mentioned this pull request Mar 29, 2024
Closed
Dhairya-Arora01 pushed a commit to Dhairya-Arora01/cluster-api that referenced this pull request May 25, 2024
@fabriziopandini @Dhairya-Arora01
馃尡 Small improvements to tilt (kubernetes-sigs#9936)
57d1e54 
* small improvements to tilt

* fix linter issues

* address comments
Dhairya-Arora01 pushed a commit to Dhairya-Arora01/cluster-api that referenced this pull request May 25, 2024
@fabriziopandini @Dhairya-Arora01
馃尡 Small improvements to tilt (kubernetes-sigs#9936)
a8f0802 
* small improvements to tilt

* fix linter issues

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@elmiko elmiko Awaiting requested review from elmiko

@enxebre enxebre Awaiting requested review from enxebre

@chrischdi chrischdi Awaiting requested review from chrischdi

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devtools Issues or PRs related to devtools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fabriziopandini @k8s-ci-robot @sbueringer @chrischdi