Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple healthz #75

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

eriksywu
Copy link
Contributor

Re: #74
I have a use-case to have the lifecycle of autoscaler pods managed by kubelet via liveness checks

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 23, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @eriksywu!

It looks like this is your first PR to kubernetes-incubator/cluster-proportional-autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/cluster-proportional-autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 23, 2020
@eriksywu
Copy link
Contributor Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 23, 2020
@eriksywu
Copy link
Contributor Author

/assign @thockin

pkg/autoscaler/health.go Outdated Show resolved Hide resolved
@eriksywu eriksywu force-pushed the add_simple_healthz branch 4 times, most recently from 74d4157 to 056fd0b Compare March 25, 2020 18:11
pkg/autoscaler/health.go Outdated Show resolved Hide resolved
pkg/autoscaler/health.go Outdated Show resolved Hide resolved
pkg/autoscaler/health.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2020
@eriksywu eriksywu force-pushed the add_simple_healthz branch 2 times, most recently from 54e369e to 804b808 Compare March 25, 2020 23:20
Copy link

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much nicer, thanks. Small point, then looks OK, I think.

cmd/cluster-proportional-autoscaler/options/options.go Outdated Show resolved Hide resolved
pkg/autoscaler/autoscaler_server.go Outdated Show resolved Hide resolved
Copy link

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Justthe spelling.

cmd/cluster-proportional-autoscaler/options/options.go Outdated Show resolved Hide resolved
@eriksywu
Copy link
Contributor Author

@thockin can you take another look? thnx

@eriksywu
Copy link
Contributor Author

/assign @MrHohn
hoping to get this merged soon

@MrHohn
Copy link
Member

MrHohn commented Mar 31, 2020

@eriksywu Could you squash the fix-up commits? Thanks.

@eriksywu
Copy link
Contributor Author

@MrHohn squashed

Copy link

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit 31d957e into kubernetes-sigs:master Apr 1, 2020
@MrHohn MrHohn mentioned this pull request Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants