-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log events that trigger reconciles #1186
Comments
I brought this up at the sig meeting, and I got the go-ahead to implement this. It was requested that this info be logged at a very high level. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Based on the comment |
On my list to shift upstream is this code https://github.com/coderanger/controller-utils/blob/e26c5734ecc941a03e9bf8798886a419e5202126/predicates/update_debug.go Would probably answer this need? |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
Rotten issues close after 30d of inactivity. Send feedback to sig-contributor-experience at kubernetes/community. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As an controller author/user, it would be helpful to know which event has triggered a reconcile, especially in situations where a reconcile can be triggered by changes to multiple resources.
What I have in mind is to log the event in the EnqueueRequestForObject event handlers: https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/handler/enqueue.go#L37-L91
The text was updated successfully, but these errors were encountered: