🐛 fix a bug in multinamespaced cache implementation #2252
Conversation
This commit fixes a bug that was brought in long ago in kubernetes-sigs#1520. When the object's scope is not deterministic from the RESTMapper it should return an error instead of ignoring it. Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
k8s-ci-robot
added
cncf-cla: yes
|
cc: @alebedev87 |
|
/lgtm |
|
@alebedev87: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thank you for fixing the bug |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cherry-pick release-0.14 |
|
@joelanford: new pull request created: #2287 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…e indexing Intial bug fix: kubernetes-sigs/controller-runtime#2252 Backport to 0.14: kubernetes-sigs/controller-runtime#2287
…e indexing Initial bug fix: kubernetes-sigs/controller-runtime#2252 Backport to 0.14: kubernetes-sigs/controller-runtime#2287
…he indexing Initial bug fix: kubernetes-sigs/controller-runtime#2252 Backport to 0.14: kubernetes-sigs/controller-runtime#2287
This commit fixes a bug that was brought in long ago in #1520. When the object's scope is not deterministic from the RESTMapper it should return an error instead of ignoring it.