-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.14] 🐛 fix a bug in multinamespaced cache implementation #2287
[release-0.14] 🐛 fix a bug in multinamespaced cache implementation #2287
Conversation
This commit fixes a bug that was brought in long ago in kubernetes-sigs#1520. When the object's scope is not deterministic from the RESTMapper it should return an error instead of ignoring it. Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k8s-infra-cherrypick-robot, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.13 Do I have rights? No way! |
@alebedev87: only kubernetes-sigs org members may request cherry picks. You can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…e indexing Intial bug fix: kubernetes-sigs/controller-runtime#2252 Backport to 0.14: kubernetes-sigs/controller-runtime#2287
…e indexing Initial bug fix: kubernetes-sigs/controller-runtime#2252 Backport to 0.14: kubernetes-sigs/controller-runtime#2287
…he indexing Initial bug fix: kubernetes-sigs/controller-runtime#2252 Backport to 0.14: kubernetes-sigs/controller-runtime#2287
This is an automated cherry-pick of #2252
/assign joelanford