✨ hack/setup-envtest.sh: install binaries and print export variable command #1258
+32
−68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup-envtest.sh script is a little clunky, since it contains a combination of global settings and functions, and your calling shell is expected to be bash. Instead, the script should only download the envtest binaries, then print what to do next (
export KUBEBUILDER_ASSETS=bin
). You can automatically do the next thing withBinaries are now installed into the argument directory directly instead of under
$1/bin
, which is more intuitive; the default is$PWD/bin
.