Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ hack/setup-envtest.sh: install binaries and print export variable command #1258

Closed

Conversation

estroz
Copy link
Contributor

@estroz estroz commented Nov 10, 2020

The current setup-envtest.sh script is a little clunky, since it contains a combination of global settings and functions, and your calling shell is expected to be bash. Instead, the script should only download the envtest binaries, then print what to do next (export KUBEBUILDER_ASSETS=bin). You can automatically do the next thing with

eval $(./setup-envtest.sh | tail -1)

Binaries are now installed into the argument directory directly instead of under $1/bin, which is more intuitive; the default is $PWD/bin.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: estroz
To complete the pull request process, please assign vincepri after the PR has been reviewed.
You can assign the PR to them by writing /assign @vincepri in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 10, 2020
@estroz
Copy link
Contributor Author

estroz commented Nov 10, 2020

/assign @vincepri

@estroz estroz force-pushed the feature/improve-setup-envtest branch from 5049c99 to 7ca7d13 Compare November 10, 2020 05:45
@estroz
Copy link
Contributor Author

estroz commented Nov 10, 2020

This should help fix problems like operator-framework/operator-sdk#4203

@k8s-ci-robot
Copy link
Contributor

@estroz: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 18, 2021
@estroz
Copy link
Contributor Author

estroz commented Feb 18, 2021

Doesn't seem to be getting attention, and I think there was affirmative discussion of providing a library to download and/or look up envtest binaries rather than rely on the wrapping shell env.

@estroz estroz closed this Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants