⚠️ Allow setting NewClientFunc w/o implementing an interface #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
alvaroaleman
changed the title
alvaroaleman
force-pushed
the
allow-new-client
branch
2 times, most recently
from
35578a3
to
ded66c7
Compare
alvaroaleman
commented
Mar 3, 2021
When we introduced the ClientBuilder we lost the ability to easily overwrite the NewClient func, as interfaces can not be implemented inline. This change reverts us back to using a NewClientFunc but with a slightly changed signature so objects that should not be cached can still be configured. In order to not provide two ways to do the same thing, the ClientBuilder is removed.
alvaroaleman
force-pushed
the
allow-new-client
branch
from
ded66c7
to
aa1bfee
Compare
k8s-ci-robot
added
size/L
alvaroaleman
changed the title
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
@alvaroaleman: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
DirectXMan12
reviewed
Jun 7, 2021
| type NewClientFunc func(cache cache.Cache, config *rest.Config, options client.Options, uncachedObjects ...client.Object) (client.Client, error) | ||
|
|
||
| // DefaultNewClient creates the default caching client | ||
| func DefaultNewClient(cache cache.Cache, config *rest.Config, options client.Options, uncachedObjects ...client.Object) (client.Client, error) { |
There was a problem hiding this comment.
we might want to consider making this options or something in the future -- this is getting a bit unwieldy
milas
added a commit
to tilt-dev/tilt
that referenced
this pull request
Jun 8, 2021
Breaking Changes: * Refactor/eliminate `ClientBuilder` to use `cluster.NewClientFunc` (see kubernetes-sigs/controller-runtime#1409) * Add stub `RemoveStreams` method on `fakePortForward` Mechanical Changes: * Upgrade K8s dependencies to v0.21.1 (aka 1.21.1) * Upgrade controller-runtime to 0.9.0 (required for K8s v0.21.1 deps) * Upgrade tilt-apiserver to v0.4.0 (requires for K8s v0.21.1 deps) * Remove `moby/term` replace (bug was fixed upstream and older version no longer compiles)
milas
added a commit
to tilt-dev/tilt
that referenced
this pull request
Jun 8, 2021
Breaking Changes: * Refactor client init to not use `ClientBuilder` (see kubernetes-sigs/controller-runtime#1409) * Add stub `RemoveStreams` method on `fakePortForward` Mechanical Changes: * Upgrade K8s dependencies to v0.21.1 (aka 1.21.1) * Upgrade controller-runtime to 0.9.0 (required for K8s v0.21.1 deps) * Upgrade tilt-apiserver to v0.4.0 (requires for K8s v0.21.1 deps) * Remove `moby/term` replace (bug was fixed upstream and older version no longer compiles)
milas
added a commit
to tilt-dev/tilt
that referenced
this pull request
Jun 9, 2021
Required Changes: * Refactor client init to not use `ClientBuilder` (see kubernetes-sigs/controller-runtime#1409) * Add stub `RemoveStreams` method on `fakePortForward` * Re-generate OpenAPI spec for K8s meta types shared by Tilt apiserver Mechanical Changes: * Upgrade K8s dependencies to v0.21.1 (aka 1.21.1) * Upgrade controller-runtime to 0.9.0 (required for K8s v0.21.1 deps) * Upgrade tilt-apiserver to v0.4.0 (requires for K8s v0.21.1 deps) * Remove `moby/term` replace (bug was fixed upstream and older version no longer compiles)
landism
pushed a commit
to tilt-dev/tilt
that referenced
this pull request
Jun 9, 2021
Required Changes: * Refactor client init to not use `ClientBuilder` (see kubernetes-sigs/controller-runtime#1409) * Add stub `RemoveStreams` method on `fakePortForward` * Re-generate OpenAPI spec for K8s meta types shared by Tilt apiserver Mechanical Changes: * Upgrade K8s dependencies to v0.21.1 (aka 1.21.1) * Upgrade controller-runtime to 0.9.0 (required for K8s v0.21.1 deps) * Upgrade tilt-apiserver to v0.4.0 (requires for K8s v0.21.1 deps) * Remove `moby/term` replace (bug was fixed upstream and older version no longer compiles)
timebertt
added a commit
to timebertt/gardener
that referenced
this pull request
Jun 16, 2021
timebertt
added a commit
to gardener/gardener
that referenced
this pull request
Jun 16, 2021
* Upgrade to k/*@v0.21.1 in go.mod * [automated] make revendor for k/* dependencies This deletes pkg/mock/client-go/kubernetes/mocks.go to resolve the following deadlock: make revendor fails because of some dependencies of the file and make generate fails because of missing revendoring. File will be generated again in the next commit. * [automated] make generate for k/* dependencies * Upgrade to c-r@v0.9.0 in go.mod * [automated] make revendor for c-r dependency `make revendor` results in `hack/setup-envtest.sh` being broken, so reset the file after running `make revendor`. Adaption to breaking changes in the upstream file will be done in a later commit. * manager.NewClientBuilder was removed in favor of cluster.DefaultNewClient ref kubernetes-sigs/controller-runtime#1409 * client.*MergeFrom* now take client.Object instead of runtime.Object ref kubernetes-sigs/controller-runtime#1395 * [automated] make generate for c-r dependency * Adapt to changes in labels.NewRequirement ref kubernetes/kubernetes#97538 * Adapt to new setup-envtest tool Makes use of the new setup-envtest tool (kubernetes-sigs/controller-runtime#1488) in hack/setup-envtest.sh instead of vendoring hack/setup-envtest.sh and fetching binaries with that. * [automated] make revendor for setup-envtest tool * Adapt pkg/envtest to upstream changes - Make use of the new Users concept in envtest to provision a dedicated user for gardener-apiserver and a valid kubeconfig - Make use of the new way to configure API server args to easily configure kube-aggregator flags - Also generate certs for aggregation layer on our own instead of reusing the API server ca/certs (which is semantically correct), which allows us to drop our fork including kubernetes-sigs/controller-runtime#1449 * Styling nits
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Upgrade to k/*@v0.21.1 in go.mod * [automated] make revendor for k/* dependencies This deletes pkg/mock/client-go/kubernetes/mocks.go to resolve the following deadlock: make revendor fails because of some dependencies of the file and make generate fails because of missing revendoring. File will be generated again in the next commit. * [automated] make generate for k/* dependencies * Upgrade to c-r@v0.9.0 in go.mod * [automated] make revendor for c-r dependency `make revendor` results in `hack/setup-envtest.sh` being broken, so reset the file after running `make revendor`. Adaption to breaking changes in the upstream file will be done in a later commit. * manager.NewClientBuilder was removed in favor of cluster.DefaultNewClient ref kubernetes-sigs/controller-runtime#1409 * client.*MergeFrom* now take client.Object instead of runtime.Object ref kubernetes-sigs/controller-runtime#1395 * [automated] make generate for c-r dependency * Adapt to changes in labels.NewRequirement ref kubernetes/kubernetes#97538 * Adapt to new setup-envtest tool Makes use of the new setup-envtest tool (kubernetes-sigs/controller-runtime#1488) in hack/setup-envtest.sh instead of vendoring hack/setup-envtest.sh and fetching binaries with that. * [automated] make revendor for setup-envtest tool * Adapt pkg/envtest to upstream changes - Make use of the new Users concept in envtest to provision a dedicated user for gardener-apiserver and a valid kubeconfig - Make use of the new way to configure API server args to easily configure kube-aggregator flags - Also generate certs for aggregation layer on our own instead of reusing the API server ca/certs (which is semantically correct), which allows us to drop our fork including kubernetes-sigs/controller-runtime#1449 * Styling nits
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Upgrade to k/*@v0.21.1 in go.mod * [automated] make revendor for k/* dependencies This deletes pkg/mock/client-go/kubernetes/mocks.go to resolve the following deadlock: make revendor fails because of some dependencies of the file and make generate fails because of missing revendoring. File will be generated again in the next commit. * [automated] make generate for k/* dependencies * Upgrade to c-r@v0.9.0 in go.mod * [automated] make revendor for c-r dependency `make revendor` results in `hack/setup-envtest.sh` being broken, so reset the file after running `make revendor`. Adaption to breaking changes in the upstream file will be done in a later commit. * manager.NewClientBuilder was removed in favor of cluster.DefaultNewClient ref kubernetes-sigs/controller-runtime#1409 * client.*MergeFrom* now take client.Object instead of runtime.Object ref kubernetes-sigs/controller-runtime#1395 * [automated] make generate for c-r dependency * Adapt to changes in labels.NewRequirement ref kubernetes/kubernetes#97538 * Adapt to new setup-envtest tool Makes use of the new setup-envtest tool (kubernetes-sigs/controller-runtime#1488) in hack/setup-envtest.sh instead of vendoring hack/setup-envtest.sh and fetching binaries with that. * [automated] make revendor for setup-envtest tool * Adapt pkg/envtest to upstream changes - Make use of the new Users concept in envtest to provision a dedicated user for gardener-apiserver and a valid kubeconfig - Make use of the new way to configure API server args to easily configure kube-aggregator flags - Also generate certs for aggregation layer on our own instead of reusing the API server ca/certs (which is semantically correct), which allows us to drop our fork including kubernetes-sigs/controller-runtime#1449 * Styling nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we introduced the ClientBuilder we lost the ability to easily
overwrite the NewClient func, as interfaces can not be implemented
inline. This change reverts us back to using a NewClientFunc but with a
slightly changed signature so objects that should not be cached can
still be configured. In order to not provide two ways to do the same
thing, the ClientBuilder is removed