Construct the typed clients we need #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
justinsb
force-pushed
the
reduce_deps_typed_clients
branch
from
5ea04d6
to
375cfae
Compare
k8s-ci-robot
added
size/M
The pattern of constructing all the clients to get a kubernetes.Interface, only to extract one or two typed clients has the side-effect of importing a lot of packages that are otherwise unneeded. Avoid doing so by constructing the clients we need. This isn't sufficient to remove all these extra dependencies (because of the use of scheme.Scheme as default), but it is a step closer.
justinsb
force-pushed
the
reduce_deps_typed_clients
branch
from
375cfae
to
a9d5651
Compare
cndoit18
reviewed
Aug 22, 2021
| @@ -24,8 +24,7 @@ import ( | |||
| "github.com/go-logr/logr" | |||
| corev1 "k8s.io/api/core/v1" | |||
| "k8s.io/apimachinery/pkg/runtime" | |||
| "k8s.io/client-go/kubernetes" | |||
| typedcorev1 "k8s.io/client-go/kubernetes/typed/core/v1" | |||
| corev1client "k8s.io/client-go/kubernetes/typed/core/v1" | |||
There was a problem hiding this comment.
Maybe we can keep the name: typedcorev1
alvaroaleman
approved these changes
Aug 22, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Construct typed clients directly
The pattern of constructing all the clients to get a
kubernetes.Interface, only to extract one or two typed clients has the
side-effect of importing a lot of packages that are otherwise
unneeded.
Avoid doing so by constructing the clients we need.
This isn't sufficient to remove all these extra dependencies (because
of the use of scheme.Scheme as default), but it is a step closer.