Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update client-go to 1.24-beta #1864

Merged
merged 1 commit into from Apr 14, 2022

Conversation

alexzielenski
Copy link
Contributor

@alexzielenski alexzielenski commented Apr 12, 2022

This PR was originally split off from #1805

Updates client-go and its dependencies to k8s 1.24-beta as well as fixes up a test which used removed API.

Please advise: There are a few k8s dependencies not included in this update such as k8s.io/apiextensions-apiserver , k8s.io/component-base. I am unsure if the procedure for updating one aspect of k8s requires updating all of it at once.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 12, 2022
@k8s-ci-robot k8s-ci-robot requested review from gerred and vincepri Apr 12, 2022
@alvaroaleman
Copy link
Member

alvaroaleman commented Apr 13, 2022

I am unsure if the procedure for updating one aspect of k8s requires updating all of it at once.

Yes, all of them need to be updated together.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 14, 2022
@alvaroaleman alvaroaleman added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 14, 2022
Copy link
Member

@alvaroaleman alvaroaleman left a comment

thanks!

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 14, 2022
@alvaroaleman
Copy link
Member

alvaroaleman commented Apr 14, 2022

@alexzielenski can you rebase please? I fixed the lint check in #1868, however gh actions does not appear to actually merge the code from the PR onto the basebranch prior to running the tests, so it doesn't pick that fix up :(

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 14, 2022

@alexzielenski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-controller-runtime-apidiff-master 3047bf4 link false /test pull-controller-runtime-apidiff-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alvaroaleman alvaroaleman removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 14, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexzielenski, alvaroaleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 954449d into kubernetes-sigs:master Apr 14, 2022
6 of 7 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.10.x milestone Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants