Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃 Update golangci-lint to 1.47.3 #1976

Merged
merged 1 commit into from Aug 11, 2022

Conversation

alvaroaleman
Copy link
Member

Updates golangci-lint in github actions

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 11, 2022
@alvaroaleman alvaroaleman changed the title Update golangci-lint to 1.48 🏃 Update golangci-lint to 1.48 Aug 11, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2022
@alculquicondor
Copy link
Contributor

It looks like some files where violating the lint

@alvaroaleman
Copy link
Member Author

Seems the latest version wants to gofmt in the (incompatible) go 1.19 style, I went back one version to not have go 1.19 support as the repo is tested with go 1.18, lets see how that goes

@alvaroaleman alvaroaleman changed the title 🏃 Update golangci-lint to 1.48 🏃 Update golangci-lint to 1.47.3 Aug 11, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 11, 2022
@alvaroaleman
Copy link
Member Author

The error assertions in the dynamic rest mappers checkAndReload never worked and fixing them makes the tests fail :/

@alculquicondor
Copy link
Contributor

The error assertions in the dynamic rest mappers checkAndReload never worked

What do you mean? The old code looked fine to me after inspection.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 11, 2022
@alculquicondor
Copy link
Contributor

/lgtm
/hold
in case you would like to have a review from an experienced contributor to this repo.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2022
@alvaroaleman
Copy link
Member Author

I think this is fine, as can be seen by the prior failures this has a very good test coverage
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit f27ed4a into kubernetes-sigs:master Aug 11, 2022
@k8s-ci-robot k8s-ci-robot added this to the v0.10.x milestone Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants