Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add tls options to manager.Options #2023

Merged
merged 1 commit into from Oct 21, 2022
Merged

✨ Add tls options to manager.Options #2023

merged 1 commit into from Oct 21, 2022

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Oct 17, 2022 •
edited

Fixes #2020

I hope I found all relevant places.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 17, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 17, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2022
@sbueringer
Copy link
Member Author

/assign @vincepri
(cc @alvaroaleman)

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2022
@sbueringer
Copy link
Member Author

@vincepri @alvaroaleman PTAL :)

alvaroaleman
alvaroaleman approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit 15d69a2 into kubernetes-sigs:master Oct 21, 2022
@sbueringer
Copy link
Member Author

@alvaroaleman Thx!
would it be okay to cherry pick this PR?

@alvaroaleman
Copy link
Member

would it be okay to cherry pick this PR?
sgtm

@sbueringer
Copy link
Member Author

/cherry-pick release-0.13

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Oct 21, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #2028

In response to this:

/cherry-pick release-0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer deleted the pr-add-tls-options branch October 21, 2022 15:28
@mythi mythi mentioned this pull request Nov 8, 2022
Closed
@periklis periklis mentioned this pull request Mar 11, 2023
Merged
5 tasks
@wu-cl wu-cl mentioned this pull request Mar 13, 2023
Merged
@ukclivecox ukclivecox mentioned this pull request Jun 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@alenkacz alenkacz Awaiting requested review from alenkacz

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@vincepri vincepri

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose TLS configuration options for default webhook server creation
5 participants
@sbueringer @k8s-ci-robot @alvaroaleman @k8s-infra-cherrypick-robot @vincepri