✨ Make setup-envtest store dir deletable for owner

[bayandin]

The current implementation of setup-envtest stores binary in a read-only directory, which (unsurprisingly) makes it hard to delete:

$ setup-envtest use --bin-dir ./tmp
$ rm -rf ./tmp
rm: ./tmp/k8s/1.26.1-darwin-arm64/etcd: Permission denied
rm: ./tmp/k8s/1.26.1-darwin-arm64/kube-apiserver: Permission denied
rm: ./tmp/k8s/1.26.1-darwin-arm64/kubectl: Permission denied
rm: ./tmp/k8s/1.26.1-darwin-arm64: Permission denied
rm: ./tmp/k8s: Permission denied
rm: ./tmp: Permission denied

In my case, I use setup-envtest in a GitHub Workflow to download binaries to .bin/ on a self-hosted runner, along with actions/checkout. And the action fails to clean up the directory in consecutive runs (so I had to do sudo rm -rf .bin in a separate step).

This PR removes setting up explicit permissions to 0555 to the store directory, and permissions are kept 0755 as set before in the following line

controller-runtime/tools/setup-envtest/store/store.go

Line 148 in c3c1f05

if err := itemPath.MkdirAll("", 0755); err != nil {

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: bayandin / name: Alexander Bayandin (3e3ea88)

[k8s-ci-robot]

Welcome @bayandin!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @bayandin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bayandin
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bayandin]

Hey @inteon & @joelanford, sorry for the ping. Is there anything I can do to help to get this PR moved?

[joelanford]

/hold

@bayandin is there some reason you're unable to use setup-envtest cleanup?

[joelanford]

@bayandin I'm going to close this PR

The intended flow here would be to run

setup-envtest cleanup --bin-dir ./tmp

which will correctly handle the read-only permissions and successfully cleanup the ./tmp directory.