Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Update to Kubernetes 1.12.3 #230

Merged
merged 2 commits into from
Dec 3, 2018

Conversation

jimmidyson
Copy link
Member

As requested in #221 (comment)

This has no breaking changes, only changes to dependencies and internal changes to work with the new version.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 2, 2018
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 2, 2018
@jimmidyson
Copy link
Member Author

Wait - I just noticed there are no differences in vendored files... so what to do here? @DirectXMan12? It's a shame we have to reference a specific tagged version of Kubernetes (e.g. kubernetes-1.12.3) rather than a branch (e.g. release-1.12). How do you feel about referencing the branch instead?

/assign @DirectXMan12

@jimmidyson
Copy link
Member Author

@DirectXMan12 @mengqiy Any time to review?

@mengqiy mengqiy changed the title Update to Kubernetes 1.12.3 ✨ Update to Kubernetes 1.12.3 Dec 3, 2018
@mengqiy
Copy link
Member

mengqiy commented Dec 3, 2018

We generally pin all the k8s dep to a released version instead of a branch. We upgrade the k8s dep about once per quarter, so these 2 approaches don't have much differences for us.

No breaking changes
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2018
@mengqiy mengqiy added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jimmidyson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jimmidyson
Copy link
Member Author

OK thanks for explaining @mengqiy. This PR follows that convention and pins to released versions. Would be good to merge :)

@k8s-ci-robot k8s-ci-robot merged commit 8f98fb7 into kubernetes-sigs:master Dec 3, 2018
@jimmidyson jimmidyson deleted the kubernetes-1.12 branch December 3, 2018 21:45
@jimmidyson
Copy link
Member Author

I want to update controller-tools but need a tag to reference there. Can someone do that please?

@mengqiy
Copy link
Member

mengqiy commented Dec 4, 2018

I want to update controller-tools but need a tag to reference there. Can someone do that please?

There are some changes we want to make about the metric support before tagging a new release.
Please expect a new release to happen this Wednesday or Thursday.

justinsb pushed a commit to justinsb/controller-runtime that referenced this pull request Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants