Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ expose NewResourceLock in manager.Options #535

Closed

Conversation

jzhoucliqr
Copy link

@jzhoucliqr jzhoucliqr commented Jul 24, 2019

This is to enable controllers to use customized resource locks for leader election.

It is for the use case that a standalone aggregation-like apiserver running without native kube-apiserver, thus the corev1 resources are not available through apiserver REST API.

With this, Mangers can use customized resourceLocks, without relying on corev1 resources.

Closes #534

@k8s-ci-robot
Copy link
Contributor

Welcome @jzhoucliqr!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jzhoucliqr
To complete the pull request process, please assign directxman12
You can assign the PR to them by writing /assign @directxman12 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 24, 2019
@jzhoucliqr jzhoucliqr changed the title :sparkles expose NewResourceLock in manager.Options ✨ expose NewResourceLock in manager.Options Jul 24, 2019
@jzhoucliqr
Copy link
Author

/retest

@k8s-ci-robot
Copy link
Contributor

@jzhoucliqr: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jzhoucliqr
Copy link
Author

@DirectXMan12 @pwittrock Do you have time to take a quick look at this PR? Thanks.

@DirectXMan12
Copy link
Contributor

I'm not sure this is the interface we want to expose -- the particulars of the resource lock are mainly an implementation detail at this point, and this adds yet another piece of client-go to our public API, which increases the chance that things will arbitrarily break in the future.

That being said, I'll have to take a closer look to see what our options are.

@DirectXMan12
Copy link
Contributor

closing in favor of #600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expose newResourceLock in manager.Options so that controllers can use customized resourceLock
3 participants