馃悰 Always shutdown etcd when stopping envtest #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
coderanger
approved these changes
May 29, 2020
fstrudel
approved these changes
May 29, 2020
|
/assign @apelisse |
This patch fixes an issue that occurs when shutting down an envtest.Environment. If the API server fails to shutdown, then the etcd process is orphaned. This can result in dozens of running etcd processes when debugging failed tests. Please see this Slack discussion for more information: https://kubernetes.slack.com/archives/CAR30FCJZ/p1590779385006000.
akutz
force-pushed
the
bugfix/envtest-shutdown-order
branch
from
5e55d55
to
4c3fca1
Compare
alvaroaleman
approved these changes
Jun 1, 2020
k8s-ci-robot
added
the
lgtm
vincepri
approved these changes
Jun 1, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akutz, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue that occurs when shutting down an
envtest.Environment. If the API server fails to shutdown, then the etcd process is orphaned. This can result in dozens of running etcd processes when debugging failed tests.Please see this Slack discussion for more information.
cc @DirectXMan12 @fstrudel