Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ CRD storage version marker #215

Merged

Conversation

droot
Copy link
Contributor

@droot droot commented May 23, 2019

This change adds support for storage version marker to indicate which version type to mark for storage.

Note: I would like to double check the name for the marker, so keeping it "do-not-merge".

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 23, 2019
@droot droot assigned DirectXMan12 and unassigned DirectXMan12 May 23, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 23, 2019
@droot droot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2019
@@ -31,6 +31,7 @@ var CRDMarkers = []*markers.Definition{
markers.Must(markers.MakeDefinition("kubebuilder:subresource:scale", markers.DescribesType, SubresourceScale{})),
markers.Must(markers.MakeDefinition("kubebuilder:printcolumn", markers.DescribesType, PrintColumn{})),
markers.Must(markers.MakeDefinition("kubebuilder:resource", markers.DescribesType, Resource{})),
markers.Must(markers.MakeDefinition("kubebuilder:conversion:storage", markers.DescribesType, StorageVersion{})),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is kubebuilder:crd:storage better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users need to specify which version is storage version, even when they don't use conversion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed.

This change adds support for storage version marker to indicate
which version type to mark for storage.
@droot droot force-pushed the feature/storage-version-marker branch from aafbb46 to 04a5e75 Compare May 29, 2019 22:30
@droot
Copy link
Contributor Author

droot commented May 29, 2019

Updated the PR and using +kubebuilder:storageversion as the marker.

@droot droot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2019
@droot
Copy link
Contributor Author

droot commented May 30, 2019

@mengqiy @DirectXMan12 Can you PTAL ? Thanks

@DirectXMan12
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, droot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3d52f49 into kubernetes-sigs:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants