-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ CRD storage version marker #215
✨ CRD storage version marker #215
Conversation
pkg/crd/markers/crd.go
Outdated
@@ -31,6 +31,7 @@ var CRDMarkers = []*markers.Definition{ | |||
markers.Must(markers.MakeDefinition("kubebuilder:subresource:scale", markers.DescribesType, SubresourceScale{})), | |||
markers.Must(markers.MakeDefinition("kubebuilder:printcolumn", markers.DescribesType, PrintColumn{})), | |||
markers.Must(markers.MakeDefinition("kubebuilder:resource", markers.DescribesType, Resource{})), | |||
markers.Must(markers.MakeDefinition("kubebuilder:conversion:storage", markers.DescribesType, StorageVersion{})), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is kubebuilder:crd:storage
better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users need to specify which version is storage version, even when they don't use conversion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed.
This change adds support for storage version marker to indicate which version type to mark for storage.
aafbb46
to
04a5e75
Compare
Updated the PR and using |
@mengqiy @DirectXMan12 Can you PTAL ? Thanks |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, droot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change adds support for storage version marker to indicate which version type to mark for storage.
Note: I would like to double check the name for the marker, so keeping it "do-not-merge".